Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: log error when ledger signing failed #3212

Merged
merged 13 commits into from
Aug 2, 2024
Merged

refactor: log error when ledger signing failed #3212

merged 13 commits into from
Aug 2, 2024

Conversation

homura
Copy link
Collaborator

@homura homura commented Jul 26, 2024 •
edited
Loading

Resolve Magickbase/neuron-public-issues#418

This PR logs error details when the ledger fails to sign a transaction to help debug the error like #3095

@homura
Copy link
Collaborator Author

homura commented Aug 1, 2024

@Keith-CY @yanguoyu I've refactored this PR, and it's ready for review

@Keith-CY Keith-CY added this pull request to the merge queue Aug 2, 2024
Merged via the queue into develop with commit 83cea84 Aug 2, 2024
21 of 23 checks passed
@Keith-CY Keith-CY deleted the log-ledger branch August 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@yanguoyu yanguoyu yanguoyu approved these changes

@devchenyan devchenyan Awaiting requested review from devchenyan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug Ledger Issues
3 participants
@homura @Keith-CY @yanguoyu